Use local random state in ot.datasets.make_data_classif
#510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #510 +/- ##
=======================================
Coverage 96.05% 96.05%
=======================================
Files 65 65
Lines 13667 13667
=======================================
Hits 13128 13128
Misses 539 539 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Switch from
np.random.randntorng.randnwhen generatingmake_data_classifdataset withdataset='2gauss_prop'.Motivation and context / Related issue
It's not desirable to change global state. And it's already done for other datasets in the same function.
How has this been tested (if it applies)
n/a
PR checklist